Skip to content

Fix windows-2025 build errors #17726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix windows-2025 build errors #17726

merged 1 commit into from
Jun 2, 2025

Conversation

adsharma
Copy link
Contributor

@adsharma adsharma commented May 30, 2025 •
edited
Loading

GHA is retiring windows-2019 runner image. This commit fixes a build error on windows-2025

The Windows Server 2019 runner image will be fully unsupported by June 30, 2025. To raise awareness of the upcoming removal, we will temporarily fail jobs using Windows Server 2019. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:

June 3 13:00-21:00 UTC
June 10 13:00-21:00 UTC
June 17 13:00-21:00 UTC
June 24 13:00-21:00 UTC

@Mytherin Mytherin merged commit 2e7b62d into duckdb:main Jun 2, 2025
46 of 47 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Jun 2, 2025

Thanks!

@adsharma adsharma deleted the windows_2025_build_fix branch June 2, 2025 16:03
Mytherin added a commit to Mytherin/duckdb that referenced this pull request Jun 3, 2025
@Mytherin
Backport duckdb#17726
a32d483
@Mytherin Mytherin mentioned this pull request Jun 3, 2025
Merged
Mytherin added a commit that referenced this pull request Jun 3, 2025
@Mytherin
Backport CI fixes (#17763)
c663b24 
Backport #17760
Backport #17220
Backport #17745
Backport #17726
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@2e7b62d
59e0a3b 
Fix windows-2025 build errors (duckdb/duckdb#17726)
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@2e7b62d (#1197)
9c3a3ec 
Fix windows-2025 build errors (duckdb/duckdb#17726)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adsharma @Mytherin