Skip to content

Pop up ICU errors to the csv sniffer #17719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Pop up ICU errors to the csv sniffer #17719

merged 2 commits into from
Jun 3, 2025

Conversation

pdet
Copy link
Contributor

@pdet pdet commented May 30, 2025

Fix: #17705

@pdet pdet changed the base branch from main to v1.3-ossivalis May 30, 2025 09:24
Mytherin
Mytherin reviewed Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one comment:

@duckdb-draftbot duckdb-draftbot marked this pull request as draft June 2, 2025 11:55
@pdet pdet marked this pull request as ready for review June 3, 2025 11:13
@Mytherin Mytherin merged commit fcb849b into duckdb:v1.3-ossivalis Jun 3, 2025
50 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Jun 3, 2025

Thanks!

@simi simi mentioned this pull request Jun 4, 2025
Closed
2 tasks
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f270019
d7bcdf9 
[Nested] Fix incorrect type casting in list_reduce lambda expressions (duckdb/duckdb#17581)
Pop up ICU errors to the csv sniffer (duckdb/duckdb#17719)
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@f270019 (#1193)
6d3e92c 
[Nested] Fix incorrect type casting in list_reduce lambda expressions (duckdb/duckdb#17581)
Pop up ICU errors to the csv sniffer (duckdb/duckdb#17719)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@pdet pdet deleted the fix_csv_tz branch July 18, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DuckDB v1.3 introduced a new error in read_csv related to date parsing.
2 participants
@pdet @Mytherin