Have the skip_rows option consider empty csv lines #17756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Have the skip_rows option consider empty csv lines (duckdb/duckdb#17756)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Have the skip_rows option consider empty csv lines (duckdb/duckdb#17756) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
skip_rowshad different behavior depending on whether it considered empty rows when skipping. This depended on whether the CSV file had one or multiple columns, which could cause confusion. Especially if the detected schema depended on the number of rows being skipped.This PR ensures that empty lines are always considered, regardless of the schema.
Fix: #17738