Output hashes in unittest and fix order #17664
Merged
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
May 26, 2025
test/sqlite/sqllogic_test_logger.hpp
Outdated
| @@ -46,7 +46,7 @@ class SQLLogicTestLogger { | |||
| void ColumnCountMismatchCorrectResult(idx_t original_expected_columns, idx_t expected_column_count, | |||
| MaterializedQueryResult &result); | |||
| void SplitMismatch(idx_t row_number, idx_t expected_column_count, idx_t split_count); | |||
| void WrongResultHash(QueryResult *expected_result, MaterializedQueryResult &result); | |||
| void WrongResultHash(QueryResult *expected_result, MaterializedQueryResult &result, string &expected_hash, string &actual_hash); | |||
There was a problem hiding this comment.
Can these be const references instead?
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
New Sorting Implementation (duckdb/duckdb#17584) Output hashes in unittest and fix order (duckdb/duckdb#17664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no information about the hashes is shown when a unittest fails because of a hash value mismatch, even though this information is readily available.
This small PR aims to include this information in the output while also making it less confusing: before, it printed an 'Expected result' header without supplying any results (or rather, printing it in the previous lines before the introductory header).