Don't bail on TopN optimization if we don't have a cardinality #17654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmonster
approved these changes
May 26, 2025
|
Thanks for the feedback! |
|
@xuke-hat Agree, but we definitely want to wait with benchmarking until #17584 is merged, which is a full reimplementation of sorting, which is much more sensitive to aborting early with a LIMIT on top This targets the bugfix release branch, while the sort rework targets the |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 2, 2025
Don't bail on TopN optimization if we don't have a cardinality (duckdb/duckdb#17654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #17140
The computation was wrong because it did not check
has_estimated_cardinalitybefore grabbing it. This PR computes the cardinality if it was not yet there. These fields should probably be changed tooptional_idxin the future so this doesn't happen.