Skip to content

chore: Fix strict aliasing warning on GCC #17641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

chore: Fix strict aliasing warning on GCC #17641

merged 3 commits into from
May 28, 2025

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented May 25, 2025 •
edited
Loading

Needed for duckdb-r 1.3.0.

@krlmlr krlmlr changed the title chore: Fix strict aliasing warning on GCC add 'Categories' label for string functions May 25, 2025
@krlmlr krlmlr changed the title add 'Categories' label for string functions chore: Fix strict aliasing warning on GCC May 25, 2025
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 25, 2025 14:23
Mytherin
Mytherin reviewed May 26, 2025
View reviewed changes
@krlmlr krlmlr force-pushed the b-strict-aliasing branch from 661fa31 to 2d8f91a Compare May 26, 2025 20:32
@krlmlr
Copy link
Collaborator Author

krlmlr commented May 26, 2025

I wonder if Load() and Store() could use a static_assert(sizeof(...) ...) .

@krlmlr krlmlr force-pushed the b-strict-aliasing branch from 2d8f91a to 1982931 Compare May 27, 2025 14:59
@krlmlr
Copy link
Collaborator Author

krlmlr commented May 27, 2025

Now using Load<float>(const_data_ptr_cast(&float32_value)) . Of course, Load() doesn't know about the size, so the static_assert() remains the user's responsibility for now. Do you think it's useful to have such a static assert in this function?

@Mytherin Mytherin marked this pull request as ready for review May 27, 2025 15:07
@Mytherin Mytherin merged commit 1bbbba9 into duckdb:v1.3-ossivalis May 28, 2025
50 checks passed
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Jun 2, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@1bbbba9
8b82488 
chore: Fix strict aliasing warning on GCC (duckdb/duckdb#17641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @Mytherin