[Nested] Fix incorrect type casting in list_reduce lambda expressions #17581
+194
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taniabogatsch
suggested changes
May 21, 2025
There was a problem hiding this comment.
Hi @maiadegraaf - thanks! I left a few comments, mostly nits around code structure and some names. :))
0da4d31 to
4e59c16
Compare
|
Thanks for the PR! LGTM - should we retarget this to |
…ype handling Now the lambda function columns match the max logical type of the list child and initial value.
377d2e2 to
0cf0a88
Compare
0cf0a88 to
74d7bd9
Compare
|
I think retargeting to |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
[Nested] Fix incorrect type casting in list_reduce lambda expressions (duckdb/duckdb#17581) Pop up ICU errors to the csv sniffer (duckdb/duckdb#17719)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
[Nested] Fix incorrect type casting in list_reduce lambda expressions (duckdb/duckdb#17581) Pop up ICU errors to the csv sniffer (duckdb/duckdb#17719) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17008
This PR fixes an issue with type casting in lambda expressions used in the
list_reducefunction.For example, in the following query:
The lambda expression was incorrectly bound as:
Now proper type casting is implemented to match the max logical type of both the list child type and the initial value type:
Test Cases
Added tests to verify the correct casting behaviour