Skip to content

Conversation

lnkuiper
Copy link
Contributor

Fixes:

Also adds some type verification to the ColumnBindingResolver.

@lnkuiper
Copy link
Contributor Author

lnkuiper commented May 19, 2025

I don't think the failing test is related

EDIT: the failing Windows test IS related, my ColumnBindingResolver type verification uncovered some issues in VSS. This should be merged though, so I'll just have to remove the verification for now.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 20, 2025 06:59
@lnkuiper lnkuiper marked this pull request as ready for review May 20, 2025 06:59
@Damon07 Damon07 mentioned this pull request May 20, 2025
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 21, 2025 07:35
@Mytherin Mytherin marked this pull request as ready for review May 22, 2025 15:55
@Mytherin Mytherin merged commit 14986f2 into duckdb:v1.3-ossivalis May 23, 2025
50 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@TheoristCoder
Copy link

Dear Developers, do you think that this PR also fix #17335?

@TheoristCoder
Copy link

Thanks!

Thanks for your effort! Do you think this issue #17335 is fixed? If you can review it, I will appreciate it!

@lnkuiper
Copy link
Contributor Author

lnkuiper commented Jun 2, 2025

@TheoristCoder I checked and the PR also fixed #17335 :)

@TheoristCoder
Copy link

@TheoristCoder I checked and the PR also fixed #17335 :)

Thanks for your fixing!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Jun 2, 2025
@TheoristCoder
Copy link

I have checked this commit 5b223b7 fixed this logic bug #17372, thanks for your fixing!

@TheoristCoder TheoristCoder mentioned this pull request Jul 5, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants