Allow installing extensions with external access allowlist #17316
+68
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14568 added a mechanism to add certain files and dirs to an allowlist to allow some IO even when
enable_external_access
is false.This PR aims to extend that to also allow installing extensions.
With this PR you can:
Note that when using absolute paths EITHER the extension directory needs to exists already OR the allowed directories should contain the path to the parent dir of the extension dir. This is because to create the extension directory,
FileSystem::DirectoryExists
needs to be called on the directory in which the extension directory will sit. So for example:SET extension_directory= '/some/path/to/extensions';
where
/some/path/to/extensions
does not exists yet will only work with: