-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. #17218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the booleans by the if: condition
…e the booleans by the if: condition
carlopi
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@carlopi, |
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220) Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions didn't provide more details in the error message, so I ran some test workflows.
We are not expecting the
InvokeCI / NotifyExternalRepository
would skipRun ODBC Vendor
job and failRun JDBC Vendor
andRun Nightly Build Status
jobs.The issue was in the boolean values passed as string inputs to the called
NotifyExternalRepository
workflow, where they were interpreted as booleans (here).This PR fixes that and adds missing
if
conditions to both workflows: to theprepare-status:
job inInvokeCI
(that job creates a flag to trigger or not the ODBC/JDBC Vendors) and to thenotify-jdbc-run
job inNotifyExternalRepositories
(to make it have the same behaviour asnotify-odbc-run
)