Skip to content

Conversation

hmeriann
Copy link
Contributor

GitHub Actions didn't provide more details in the error message, so I ran some test workflows.

We are not expecting the InvokeCI / NotifyExternalRepository would skip Run ODBC Vendor job and fail Run JDBC Vendor and Run Nightly Build Status jobs.

The issue was in the boolean values passed as string inputs to the called NotifyExternalRepository workflow, where they were interpreted as booleans (here).

This PR fixes that and adds missing if conditions to both workflows: to the prepare-status: job in InvokeCI (that job creates a flag to trigger or not the ODBC/JDBC Vendors) and to the notify-jdbc-run job in NotifyExternalRepositories (to make it have the same behaviour as notify-odbc-run)

@hmeriann hmeriann requested a review from carlopi April 23, 2025 12:17
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 23, 2025 12:51
@hmeriann hmeriann marked this pull request as ready for review April 23, 2025 12:58
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 24, 2025 09:11
@hmeriann
Copy link
Contributor Author

hmeriann commented Apr 24, 2025

@carlopi,
after discussion with @staticlibs I've realised that have to update this PR because it used workflow inputs containing extra single quotes ("'true'"/"'false'") to pass them to the NotifyExternalRepositories.

@hmeriann hmeriann marked this pull request as ready for review April 24, 2025 14:06
@Mytherin Mytherin merged commit 4ba87eb into duckdb:main Apr 30, 2025
2 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220)
Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220)
Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 19, 2025
Add "thousands" option to CSV Reader (duckdb/duckdb#17220)
Fix [InvokeCI / NotifyExternalRepository] GitHub Actions has encountered an internal error when running your job. (duckdb/duckdb#17218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants