Extract expressions from nested conjunction AND for index scan #17297
+88
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi, @lnkuiper, cool! - I've added some comments/thoughts. :)
taniabogatsch
approved these changes
Apr 29, 2025
|
Thanks for the PR! LGTM - could you just fix the failing vector sizes test? |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Extract expressions from nested conjunction AND for index scan (duckdb/duckdb#17297)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Extract expressions from nested conjunction AND for index scan (duckdb/duckdb#17297)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Extract expressions from nested conjunction AND for index scan (duckdb/duckdb#17297)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Extract expressions from nested conjunction AND for index scan (duckdb/duckdb#17297)
Mytherin
added a commit
that referenced
this pull request
Jul 2, 2025
I was looking into duckdblabs/duckdb-internal#5049 and tried converting some of our `MARK` joins to `SEMI` joins. This didn't fix the issue I was looking at (and regressed the IMDB benchmark, so I reverted it), but it uncovered a bug in the dynamic index scan (which I accidentally introduced in #17297). This PR cleans up the recursion through the nested `AND` filters and simplifies the logic so it's a lot less error-prone. I have tried, but can't seem to reproduce it without changing the `MARK` to `SEMI`. However, I still think the changes here are important as they fix a bug with complex filters that can trigger an index scan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/4742
We did not recurse into nested conjunction
ANDexpressions, causing us to bail on using an Index Scan, even though this would be much faster than the Sequential Scan.