-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Nested] Fix: 16489 - Find NULL
s in lists using list_position
#17080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e252735
to
855f2e8
Compare
Failing CI is unrelated. |
taniabogatsch
approved these changes
Apr 30, 2025
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Nested] Fix: 16489 - Find `NULL`s in lists using `list_position` (duckdb/duckdb#17080)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Nested] Fix: 16489 - Find `NULL`s in lists using `list_position` (duckdb/duckdb#17080)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Nested] Fix: 16489 - Find `NULL`s in lists using `list_position` (duckdb/duckdb#17080)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Nested] Fix: 16489 - Find `NULL`s in lists using `list_position` (duckdb/duckdb#17080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when calling
list_position([1, 2, 3, NULL], NULL)
, the function would always returnNULL
instead of the index of theNULL
element. This behavior differed from PostgreSQL. This PR fixes the issue, so thatlist_position
now correctly returns the index of the element, regardless of whether or not it isNULL
.This PR builds on: #16969
Fixes: #16489