Fix httpfs patches: avoid git log since might contain unsanitised error word
#17075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terpreted by cmake's populate as an... error
I love technology |
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Apr 11, 2025
This is not intended to be merged, only to demo duckdb#17075 actually does something of relevance
git log since might contain unsanitised error word
|
A/B testing experiment with a PR with only one of this commits did fail as expected #17077. This is ready to be merged on my side. |
|
I have also pushed this as part of #17071 |
|
Feel free to merge yours first, but I do like this PR, don't close it please. Bragging rights are relevant. |
|
Thanks :) |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Nested] Optimize List Type in `list_value` (duckdb/duckdb#17063) Re-enable Avro on core (duckdb/duckdb#17072) Fix httpfs patches: avoid `git log` since might contain unsanitised `error` word (duckdb/duckdb#17075)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Nested] Optimize List Type in `list_value` (duckdb/duckdb#17063) Re-enable Avro on core (duckdb/duckdb#17072) Fix httpfs patches: avoid `git log` since might contain unsanitised `error` word (duckdb/duckdb#17075)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Nested] Optimize List Type in `list_value` (duckdb/duckdb#17063) Re-enable Avro on core (duckdb/duckdb#17072) Fix httpfs patches: avoid `git log` since might contain unsanitised `error` word (duckdb/duckdb#17075)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Nested] Optimize List Type in `list_value` (duckdb/duckdb#17063) Re-enable Avro on core (duckdb/duckdb#17072) Fix httpfs patches: avoid `git log` since might contain unsanitised `error` word (duckdb/duckdb#17075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
git logwhile applying patches, that will print a bunch of content to stdout.The stdout then might (or not) contain the word error, interpreted by MSBuild's cmake as an... error.
Thanks to the internet, at https://stackoverflow.com/questions/78622876/visual-studio-msbuild-error-msb8066-custom-build and https://developercommunity.visualstudio.com/t/MSBuild:-error:-output-of-custom-build/10554390?sort=newest, and @ccfelius that first raised the problem.
Fixes #16177, also reverts #16722.
This should unlock #16196 and #16463.