MultiFileReader Rework (part 18): Replace file path with OpenFileInfo struct
#17071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of having a OpenFileInfo struct that can carry more info than just the string path. But have you considered also making Glob return something more than just a vector of OpenFileInfos? E.g. some sort of Also I think |
|
The idea is to add extra members to The design I have for it in my follow-up branch is this: struct ExtendedOpenFileInfo {
unordered_map<string, Value> options;
};
struct OpenFileInfo {
OpenFileInfo() = default;
OpenFileInfo(string path_p) // NOLINT: allow implicit conversion from string
: path(std::move(path_p)) {
}
string path;
shared_ptr<ExtendedOpenFileInfo> extended_info;
public:
bool operator<(const OpenFileInfo &rhs) const {
return path < rhs.path;
}
};I think reworking glob to return an iterator is also a good idea - but somewhat orthogonal to this PR. |
|
Ah alright, I guess that makes sense. I guess |
Mytherin
added a commit
that referenced
this pull request
Apr 14, 2025
…on keys and footer size to Parquet reader (#17085) Follow-up to #17071 This PR extends the `OpenFileInfo` struct with `ExtendedOpenFileInfo`: ```cpp struct ExtendedOpenFileInfo { unordered_map<string, Value> options; }; ``` The Parquet reader is extended to support two keys in this struct: * `encryption_key`: used to pass a global encryption key for the Parquet file to the reader * `footer_size`: used to pass the footer size of the Parquet file to the reader. This can be used to skip the separate reading of the footer length from the back of the file - instead we can directly read the footer. Note that this must be exactly correct - an error is thrown if an incorrect footer size is provided.
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
MultiFileReader Rework (part 18): Replace file path with `OpenFileInfo` struct (duckdb/duckdb#17071) update julia to v1.2.2 (duckdb/duckdb#17074)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
MultiFileReader Rework (part 18): Replace file path with `OpenFileInfo` struct (duckdb/duckdb#17071) update julia to v1.2.2 (duckdb/duckdb#17074)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
MultiFileReader Rework (part 18): Replace file path with `OpenFileInfo` struct (duckdb/duckdb#17071) update julia to v1.2.2 (duckdb/duckdb#17074)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
MultiFileReader Rework (part 18): Replace file path with `OpenFileInfo` struct (duckdb/duckdb#17071) update julia to v1.2.2 (duckdb/duckdb#17074)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
MultiFileReader Rework (part 18): Replace file path with `OpenFileInfo` struct (duckdb/duckdb#17071) update julia to v1.2.2 (duckdb/duckdb#17074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks several parts of the file system and multi file reader to work on an extensible
OpenFileInfostruct instead of astring path:OpenFileExtendedtakes anOpenFileInfoGlobreturns a list ofOpenFileInfoOpenFileInfo(including theMultiFileListthat returns a list ofOpenFileInfo)The idea here is that we can pass per-file information down to the readers and file system that can avoid doing unnecessary work. For example:
This PR does not change anything aside from wrapping the paths into a struct - but that will allow these optimizations in a follow-up PR.