[Python] Fix PyArrow filter pushdown for NaN #16952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity with core duckdb NaN ordering
ec21ac2 to
d3970ae
Compare
|
Thanks! Looks great |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 8, 2025
Allow overriding the Printer::Print output destination (duckdb/duckdb#16909) [Python] Fix PyArrow filter pushdown for NaN (duckdb/duckdb#16952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16942
As mentioned here DuckDB does not follow the IEEE-754 behavior for nan comparisons, instead it makes NaN the biggest value in the floating point ordering.
This PR adjusts the pyarrow dataset filters we create when pushing DuckDB table filters in to pyarrow.