Regression.yml: Actually checkout proper base.sha commit #16824
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Revert up in #16860 - this seems to cause CI to fail at times - not sure why exactly (e.g. - https://github.com/duckdb/duckdb/actions/runs/14094223907/job/39478033537?pr=16838) |
|
Thanks, revert is great. Not sure either. |
Mytherin
added a commit
that referenced
this pull request
Mar 27, 2025
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would blindly checkout
main, but that might change between when a PR is sent and when it's evaluated (due to other PR being merged in the timeline of a PR).Now move to use
github.event.pull_request.base.shafor pull_requests.Problem discovered with @c-herrewijn looking at hard to justify behaviour on a PR of his.