fix: drop useless python import #16808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
approved these changes
Mar 24, 2025
lint fixed will figure out why failed a case today seems can not change pyi will revert pyi files update do not touch pyi files oh finally |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
94c7b21 to
7ddc633
Compare
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
|
Thanks! |
Mytherin
added a commit
that referenced
this pull request
Mar 25, 2025
|
I've ended up reverting this in #16834 - this seems to have broken a bunch of CI jobs and caused other issues. I think the import checker has a bunch of holes that make it not work correctly across Python versions (i.e. some imports are useless on Python 3.11 but required for Python 3.10). |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drop useless python import.
when using some code from duckdb found that, some of python import are useless
so using ruff to static check and drop them(do not touch the warnign which maybe useful)
command:
pip install ruff ruff check --fix --select F401 .