Add storage_version 66 for version 1.3.0 #16800
Merged
+49
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make so that `SELECT tags FROM duckdb_databases()` results will remain stable while new versions of DuckDB (either patches or minor) are added, since only the lower bound (that will stay fixed) is returned. If upper bound is desirable, I would consider adding a different table function returning the actual mapping, and via SQL the full bound can be reconstructed. Also adding a test on storage 66 (introduced in v1.3.0) to be compatible.
Tishj
reviewed
Mar 24, 2025
|
Failure is tracked at https://github.com/duckdblabs/duckdb-internal/issues/4499, not connected to this PR. |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Add storage_version 66 for version 1.3.0 (duckdb/duckdb#16800) Benchmark runner summary (duckdb/duckdb#16759) NightlyTests.yml: Inline env variables into build command (duckdb/duckdb#16817) fix: drop useless python import (duckdb/duckdb#16808) Regression.yml: Actually checkout proper base.sha commit (duckdb/duckdb#16824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
v1.2-histrionicusv1.3.0SELECT tags['storage_version'] FROM duckdb_databases()so that only lower bound is returnedthis should make so that result is stable across duckdb versions, and as a side effect tests will also be valid across duckdb version
unsure if adding a table function with the whole mapping might be of use, that would allow via SQL to reconstruct the full bounds.
This PR do not introduce any change that is actually backward incompatible and requiring a version bump, but there are in-flight PRs such as #15637 or #16648 that can then make use of this