Add libs folder to bundled static libs #16654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will close and move to histrionicus |
Mytherin
added a commit
that referenced
this pull request
Mar 17, 2025
For some OS + architecture combinations, the bundled static libraries exceed 100MB, which can be inconvenient. This PR adds a gather-libs target that collects the individual libraries (pre-bundling) and puts them in a libs folder. When publishing the existing artifact, it also zips that additional libs folder. Follow-up to #16654.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some OS + architecture combinations, the bundled static libraries exceed 100MB, which can be inconvenient.
This PR adds a
gather-libstarget that collects the individual libraries (pre-bundling) and puts them in a libs folder. When publishing the existing artifact, it also zips that additional libs folder.Here's an example run: https://github.com/taniabogatsch/duckdb/actions/runs/13853813704