[Fix] Perform eager constraint checking during physical batch insert #16651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you @taniabogatsch 🙏 - I'll give this fix a try on weekend and reply back! |
|
@taniabogatsch - confirm this PR fixes issue below 🚀. Thank you and will be looking forward to 1.2.2 duckdb release ./load_lineitem.sh
v1.2.2-dev34 a257b0b0bd
100% ▕████████████████████████████████████████████████████████████▏
┌──────────────────────┐
│ initial_insert_count │
│ int64 │
├──────────────────────┤
│ 1000 │
└──────────────────────┘
┌──────────────────┐
│ count_after_drop │
│ int64 │
├──────────────────┤
│ 0 │
└──────────────────┘
100% ▕████████████████████████████████████████████████████████████▏
┌──────────────────────┐
│ count_after_reinsert │
│ int64 │
├──────────────────────┤
│ 1000 │
└──────────────────────┘
Overwrite attempt completed. |
sgrebnov
approved these changes
Mar 15, 2025
|
Thanks! |
This was referenced Mar 17, 2025
|
should we add test from the reproducible queries from #16604 |
|
Oh, I thought that I had, I even mentioned it in the PR description - I probably forgot to check them in... 😅 |
|
Will open a PR :) |
Mytherin
added a commit
that referenced
this pull request
Mar 20, 2025
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 8, 2025
[Fix] Perform eager constraint checking during physical batch insert (duckdb/duckdb#16651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16604.
Fixes #16520.
I added the reproduction for #16604. #16520 is more complicated to include in the tests as it fetches a remote file. Both use
INSERT INTO tbl SELECT * FROM other_tbl, which triggers the physical batch insert code.I've also quickly confirmed #16604 locally, but maybe @sgrebnov, you want to check out this PR and try it yourself.