Skip to content

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Mar 14, 2025

This is one out of three PRs to avoid accessing uninitialized memory. This change was necessary to satisfy CRAN's incoming checks.

CRAN uses gcc 14.2.0 with compile commands similar to the following:

g++  -std=gnu++17 -DNDEBUG -I... -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign    -c duckdb/ub_src_common_types_row.cpp -o duckdb/ub_src_common_types_row.o

I believe they are looking for -Wuninitialized and -Wmaybe-uninitialized .

Would you consider having similar checks as part of the CI/CD pipeline here, perhaps with -Werror ?

@krlmlr krlmlr changed the base branch from main to v1.2-histrionicus March 14, 2025 08:30
@Mytherin Mytherin marked this pull request as draft March 17, 2025 08:56
@Mytherin Mytherin marked this pull request as ready for review March 17, 2025 08:57
@Mytherin Mytherin merged commit bc4441b into duckdb:v1.2-histrionicus Mar 17, 2025
49 checks passed
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants