LinuxRelease.yml: Pass down override git describe #16521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
bump spatial again (duckdb/duckdb#16518) LinuxRelease.yml: Pass down override git describe (duckdb/duckdb#16521) CI Fixes after upgrade to ubuntu 22 (duckdb/duckdb#16516) bump spatial and excel for v1.2 (duckdb/duckdb#16504) Move from ubuntu-20:04 to ubuntu-22:04, part II (duckdb/duckdb#16514) [chore] Build Linux releases also on PRs AND ubuntu-20 to 22 (duckdb/duckdb#16506) Move from ubuntu-20:04 to ubuntu-22:04, part I (duckdb/duckdb#16510) CodeQuality: ubuntu-20 to ubuntu-22, lock black to version 24 and trick clang_format detection (duckdb/duckdb#16513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This do not change anything on the regular path, but do pass down what should be overridden.
I am testing this on my fork by providing a bogus descriptor, looks to behave as expected (https://github.com/carlopi/duckdb/actions/runs/13670863693/job/38220629656)
Important thing: this do not change anything on a regular path where an override is not provided, so CI here should be mostly checking for nonsense.