-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Julia] Add support for appending duckdb List types #16512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are currently converted to BLOB and not UTINYINT[].
Thanks! |
Mytherin
added a commit
that referenced
this pull request
Mar 18, 2025
Hi DuckDB team! I am submitting a very small PR to improve value binding to parameters in prepared statements. This is especially important when using the SQL `IN` operator, for example. I have tried to follow the contribution guide, and included a small test. Previously we could not bind vectors to parameters, the code in the tests would fail (relevant snippet below). This PR fixes this behavior. ```julia stmt = DBInterface.prepare(con, "FROM test_table WHERE i IN ?;") results = DBInterface.execute(stmt, ([1,2], )) df = DataFrame(results) ``` With the following error: ```julia ERROR: unsupported type for bind Stacktrace: [1] duckdb_bind_internal(stmt::DuckDB.Stmt, i::Int64, val::Vector{Int64}) @ DuckDB ~/.julia/packages/DuckDB/vI6tj/src/statement.jl:72 [2] bind_parameters(stmt::DuckDB.Stmt, params::Tuple{Vector{Int64}}) @ DuckDB ~/.julia/packages/DuckDB/vI6tj/src/statement.jl:78 [3] execute(stmt::DuckDB.Stmt, params::Tuple{Vector{Int64}}) @ DuckDB ~/.julia/packages/DuckDB/vI6tj/src/result.jl:709 [4] execute(stmt::DuckDB.Stmt, params::Tuple{Vector{Int64}}) @ DuckDB ~/.julia/packages/DuckDB/vI6tj/src/result.jl:872 [5] top-level scope @ ~/some-path-removed-for-security ``` Thanks to the new support for List types provided in #16512 the same code now returns: ```julia julia> df = DataFrame(results) 4×2 DataFrame Row │ i j │ Int32 Float64 ─────┼──────────────── 1 │ 1 3.5 2 │ 2 0.5 3 │ 1 1.0 4 │ 2 2.0 ```
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
regex_replace no longer swallows regex errors (duckdb/duckdb#16380) [PySpark] - Add `expr` function (duckdb/duckdb#16468) [Julia] Add support for appending duckdb List types (duckdb/duckdb#16512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for appending duckdb List types.
Except Vector{UInt8} types are currently converted to BLOB and not UTINYINT[], which would be a breaking change.