[Python Dev] No longer trigger a DeprecationWarning when using a UDF #16433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mytherin I'm also pointing this at v1.2, I think the changes are small enough for that |
…ing, we sidestep that warning now
f796de4 to
f29b159
Compare
|
Given that this doesn't really fix anything yet and you indicate there is some risk to this maybe pushing it into |
|
I wrote that before the CI was green, but yes that's something to be mindful off. I can run nightly on my fork and see what the results of that are, if that's green I think it should make 1.2.1 |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 8, 2025
Give preference to quote=escape if we can't do better (duckdb/duckdb#16584) Fixup problems connected to prep to 1.2.1 (duckdb/duckdb#16578) [Python Dev] No longer trigger a DeprecationWarning when using a UDF (duckdb/duckdb#16433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16370
Numpy has deprecated access to
numpy.corein 2.0.0, we need to make suremultiarraydoes not get imported by a non-main thread for the first time, as this causes a segfault.multiarrayis sadly not exposed through the public API, so we kind of jump through a couple hoops to not trigger the warning anymore, while still remaining backwards compatible.What does scare me a little is that I did not run into the DeprecationWarning during testing, so I wonder if accessing
multiarrayin this roundabout fashion is taking the right path, if it's not then we could still run the risk of running into the aforementioned segfault.