Add storage and serialization version for v1.2.1 #16403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM - could you just have a look at the failing tests? |
|
I have updated the tests to expect the new name "v1.2.0 - v1.2.1" for the storage version tag. |
|
Not for this PR, but connected: do we might want to change the results OR adapt the tests to filter only the start instead of the range. Maybe: (either directly as result or filtering results to the first X chars) |
|
Thanks!
Yes that makes sense |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Add storage and serialization version for v1.2.1 (duckdb/duckdb#16403)
Mytherin
added a commit
that referenced
this pull request
Mar 24, 2025
…h release (#16799) This is equivalent to #16403, problem is still open of handling this in a more general way to avoid PRs like this one. I think for `v1.2.2` is fine do to this manually, on `main` it would be cool to handle this so that only on introducing a different version this will require changes, but adding a patch release should touch src/storage/version_map.json but not the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates version_map.json to include a storage and serialization version for the upcoming v1.2.1 release