[tests] Add allow_unsigned_extensions require #16499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this only adds the setting, but unittests currently still default to allow_unsigned_extensions=1 AND there is (currently) no way to set it. Still it's relevant to have the test handled
|
This passed also CI on the python unittester, that i might had not tested locally (https://github.com/carlopi/duckdb/actions/runs/13649189497/job/38153734939). This PR should be irrelevant, but simplifies more testing. |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Provide callback when tasks are starting / stopping (duckdb/duckdb#16451) [tests] Add allow_unsigned_extensions require (duckdb/duckdb#16499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only adds a currently unused require to test that do require loading of local extensions.
This change allow to separate tests that can't be run if ones where to set
allow_unsigned_extensionsto false.Note that there are yet no changes checked in that will actually use this feature, but it's used to stress testing
signed extensions for example in https://github.com/carlopi/duckdb/actions/runs/13648796593/job/38152545371#step:11:4076.