fix passing a null path to the C API instance cache #16474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
fix passing a null path to the C API instance cache (duckdb/duckdb#16474) [Python Dev] Make `pandas` not required in a couple places, check if it's installed in others (duckdb/duckdb#16414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on exposing the instance cache through Node Neo using the C API, I found that passing
nullptrto thepathargument ofduckdb_get_or_create_from_cacheresulted in a seg fault. Note thatduckdb_openacceptsnullptrjust fine. Both functions are documented to acceptnullptr.This occurred because the C++ API takes a
duckdb::string, which can't containnullptr, but the C API was passing in aconst char *that could benullptr. The simple fix is to check fornullptrin this case and pass an empty string instead.I added a few basic tests of this function for various special values of the
pathargument:nullptr, empty string, and":memory:". Thenullptrtest case fails without this fix; the other two are fine.Note that I'm submitting this PR to the
v1.2-histrionicusbranch in the hopes it can get in before the release of 1.2.1 this week.