custom_extension_repository to also be the default autoinstall_extension_repository #16459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are 2 settings that need to be overridden to change the default (remote) extension repository:
Having those point to different endpoint I think it's an historical artifact, and mostly used to test autoinstall and autoloading in our unittester.
Documentation do not mention
autoinstall_extension_repository
at all, and I think users would assume settingcustom_extension_repository
should download from that one both these cases:The proposed solution, that I think should keep flexibility when needed (e.g. testing framework) while keeping most current workflow working is using
custom_extension_repository
as default whenautoinstall_extension_repository
is not set.Added a test, that in current DuckDB fails while INSTALLing the extension from default repo (even though
custom_extension_repository
had been set):Fixes also a minor mistake within an
#ifdef
.