Provide callback when tasks are starting / stopping #16451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
commented
Feb 27, 2025
| @@ -247,7 +247,7 @@ void AttachedDatabase::Close() { | |||
| } | |||
| CheckpointOptions options; | |||
| options.wal_action = CheckpointWALAction::DELETE_WAL; | |||
| storage->CreateCheckpoint(options); | |||
| storage->CreateCheckpoint(nullptr, options); | |||
There was a problem hiding this comment.
This is the only place where we're missing out on a ClientContext, which I think is fine though.
Mytherin
reviewed
Mar 3, 2025
|
Thanks, fixed :) |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Provide callback when tasks are starting / stopping (duckdb/duckdb#16451) [tests] Add allow_unsigned_extensions require (duckdb/duckdb#16499)
Mytherin
added a commit
that referenced
this pull request
Apr 8, 2025
Follow-up to #16451 that fixes the situation where checkpoint / vacuum tasks would not be correctly identified as belonging to a given query / transaction because the ClientContext wasn't correctly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows extensions to do further instrumentation around tasks, e.g. install a custom thread context.