Adding windows code signing using azure #16444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks right! Should we give this a go for v1.2.1 (if so, needs retargeting to Either way proper test is after merge on the first invocation of Windows.yml (that can also be triggered on purpose, just to reduce latency) |
7435c5a to
16f7294
Compare
|
re-targeted to 1.2 should be good to go, we'll see after merge |
|
Awesome, thanks! |
|
Looks like it worked https://github.com/duckdb/duckdb/actions/runs/13568920626/job/37928568179 |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
CSV small code Improvements + initialising boolean variable. (duckdb/duckdb#16454) Adding windows code signing using azure (duckdb/duckdb#16444) Bump delta to working commit (duckdb/duckdb#16442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% on the conditional
perhaps someone else knows more or we just need a few attempts