Update shell.cpp to fix #16333 #16335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed fix for duckdb#16333 as it seems SetColumnRendering and SetRowRendering do the same thing instead of SetRowRendering returning state.columns back to the default value.
|
This replaces #16334 |
|
Thanks for the swift fix! For future reference, you can just rebase your branch, you don't need to close and open a new PR Afterwards on the website you can |
|
Thank you! @Tishj! Very much appreciate the better approach. I didn't know how to do that off-hand but also didn't have access to a terminal with the right user account so recreating ended up faster anyways. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Add the suggestion to verify the nullstring as part of the cast error message (duckdb/duckdb#16336) Update shell.cpp to fix duckdb/duckdb#16333 (duckdb/duckdb#16335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #16333 as it seems SetColumnRendering and SetRowRendering do the same thing instead of SetRowRendering returning state.columns back to the default value.