Update shell.cpp addressing #16333 #16334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed fix for duckdb#16333 as it seems `SetColumnRendering` and `SetRowRendering` do the same thing instead of `SetRowRendering` returning `state.columns` back to the default value.
|
Thanks for the PR! LGTM - could you rebase it to the branch |
|
Will close and re-open for reasons of troublesome client-side issues on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #16333 as it seems
SetColumnRenderingandSetRowRenderingdo the same thing instead ofSetRowRenderingreturningstate.columnsback to the default value.