-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Rename DUCKDB_API
to DUCKDB_C_API
for duckdb.h
#16397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DUCKDB_API
definition between duckdb.h
and winapi.hpp
DUCKDB_API
definition between duckdb.h
and winapi.hpp
for MinGW
I've launched a nightly test run here - https://github.com/Mytherin/duckdb/actions/runs/13518555521 |
Turns out the reason this changed is that |
I was looking at the man page for
Maybe adding one of these options to the compile commands of the C-API files with inlined exported functions is also another way to approach this? |
DUCKDB_API
definition between duckdb.h
and winapi.hpp
for MinGWDUCKDB_API
to DUCKDB_C_API
for duckdb.h
After struggling with this for a bit I've solved it in a different manner - by switching the name of the definition in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realise until now the two macros are meant for different things! This seems like a reasonable solution to me (in my non-expert opinion 😃).
I tested this PR with my build script, followed by a check of the symbols, everything is fixed.
Rename `DUCKDB_API` to `DUCKDB_C_API` for `duckdb.h` (duckdb/duckdb#16397)
Follow-up fix from #16396 - thanks suvayu for all of the work on figuring this out.