Aggregation: For dictionaries without an id - use the correct threshold to bail-out on using the dictionary #16364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
referenced
this pull request
Feb 23, 2025
…and use this in the aggregate HT to cache look-ups
Thanks for the explanation! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Aggregation: For dictionaries without an id - use the correct threshold to bail-out on using the dictionary (duckdb/duckdb#16364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should bail-out when
dict_size * DICTIONARY_THRESHOLDis bigger than the number of rows in the chunk, not the other way around.Note that in practice this code doesn't really get triggered right now because we only emit dictionary vectors with ids.