Fix -std=c++11 #16237
Merged
Fix -std=c++11 #16237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/duckdb/duckdb/blob/main/tools/pythonpkg/setup.py#L162 and L165, but then reset again at https://github.com/duckdb/duckdb/blob/main/tools/pythonpkg/setup.py#L176 but incorrectly for all compilers.
2 tasks
|
Thanks! |
|
The title is "fix", if this was called "remove" I would have looked at it, because this isn't fixing I'll try to find a solution that fixes this for all platforms |
|
This doesn't sound like it's possible to reliably detect reading through some related work on the topic of detecting MSVC |
|
Can we just use |
|
Do we care about differentiating between MinGW and MSVC? Because that check does not differentiate |
|
I don't think we do |
This was referenced Feb 17, 2025
|
Sorry, didn't mean to break a build! Why wouldn't the c++11 flag be set a few line above in the code though? You likely do want to distinguish between msvc and mingw because the compiler flags are different. It is easy to tell from CMAKE, _WIN32 will be set as well as GCC (or _MSC_VER will or won't be set). Maybe that could be passed in to the python code? |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 3, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is invalid with MSVC. It it is set correctly here - https://github.com/duckdb/duckdb/blob/main/tools/pythonpkg/setup.py#L162 and L165, but then reset again at https://github.com/duckdb/duckdb/blob/main/tools/pythonpkg/setup.py#L176 but incorrectly for all compilers.