Use _win32 with MSVC #16235
Merged
Use _win32 with MSVC #16235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…define for MSVC (and I believe mingw64 these days) - see https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
2 tasks
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 3, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Issue duckdb/duckdb#8265: AsOf Nested Loop (duckdb/duckdb#16218) Fix -std=c++11 (duckdb/duckdb#16237) Fix Python 3 executable name on Windows (duckdb/duckdb#16236) Use _win32 with MSVC (duckdb/duckdb#16235) Do In-Filter pushdown in PyArrow (duckdb/duckdb#16224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building Duckdb on Windows with MSVC 2022. _win32 is the correct define for MSVC (and I believe mingw64 these days) - see https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170