Skip to content

[fix] Use bigobj when building with MSVC #16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

[fix] Use bigobj when building with MSVC #16200

merged 1 commit into from
Feb 12, 2025

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Feb 12, 2025

Fixes build error:

FAILED: extension/core_functions/aggregate/holistic/CMakeFiles/duckdb_core_functions_holistic.dir/ub_duckdb_core_functions_holistic.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1442~1.344\bin\Hostx64\x64\cl.exe   /TP -DDUCKDB_BUILD_LIBRARY -DDUCKDB_EXTENSION_AUTOINSTALL_DEFAULT=1 -DDUCKDB_EXTENSION_AUTOLOAD_DEFAULT=1 -DEXT_VERSION_CORE_FUNCTIONS=\"v1.2.0\" -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\src\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\fsst -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\fmt\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\hyperloglog -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\fastpforlib -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\skiplist -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\fast_float -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\re2 -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\miniz -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\utf8proc\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\concurrentqueue -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\pcg -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\tdigest -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\mbedtls\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\jaro_winkler -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\yyjson\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\third_party\zstd\include -ID:\b\duckdb\src\v1.2.0-433bb02763.clean\extension\core_functions\include /nologo /DWIN32 /D_WINDOWS /utf-8 /GR /EHsc /MP  /wd4244 /wd4267 /wd4200 /wd26451 /wd26495 /D_CRT_SECURE_NO_WARNINGS /utf-8 /MDd /Z7 /Ob0 /Od /RTC1  -MDd /showIncludes /Foextension\core_functions\aggregate\holistic\CMakeFiles\duckdb_core_functions_holistic.dir\ub_duckdb_core_functions_holistic.cpp.obj /Fdextension\core_functions\aggregate\holistic\CMakeFiles\duckdb_core_functions_holistic.dir\ /FS -c D:\b\duckdb\x64-windows-dbg\extension\core_functions\aggregate\holistic\ub_duckdb_core_functions_holistic.cpp
D:\b\duckdb\x64-windows-dbg\extension\core_functions\aggregate\holistic\ub_duckdb_core_functions_holistic.cpp : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

@Mytherin Mytherin merged commit ba8eaca into duckdb:main Feb 12, 2025
47 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 27, 2025
@Antonov548
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
5955af2 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
@Antonov548 @krlmlr
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
2e7fa50 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
7eb2ae8 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
80b1da1 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
626856e 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@1ee8a17
c678f9f 
Improve performance of `UNNEST/UNPIVOT` by using selection vectors to unnest multiple lists at once (duckdb/duckdb#16210)
[fix] Use bigobj when building with MSVC (duckdb/duckdb#16200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-kuhn @Mytherin