Skip to content

[Fix] MinGW bundle static libs #16292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

[Fix] MinGW bundle static libs #16292

merged 2 commits into from
Feb 19, 2025

Conversation

taniabogatsch
Copy link
Contributor

  • Enable autoload and autoinstall
  • Statically link and bundle the default extensions

carlopi
carlopi reviewed Feb 18, 2025
View reviewed changes
@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 18, 2025 15:47
carlopi
carlopi approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work, so OK, but some effort in fixing some of the added complexity would be eventually nice.

@taniabogatsch taniabogatsch marked this pull request as ready for review February 18, 2025 20:50
@Mytherin Mytherin merged commit 8d50790 into duckdb:v1.2-histrionicus Feb 19, 2025
55 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@taniabogatsch taniabogatsch deleted the mingw-bundle-fix branch February 19, 2025 09:13
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Mar 7, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@cabb9db
bf7f2ee 
Fix heap buffer oveflow sampling (duckdb/duckdb#16279)
[Fix] MinGW bundle static libs (duckdb/duckdb#16292)
@taniabogatsch taniabogatsch mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@carlopi carlopi carlopi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taniabogatsch @Mytherin @carlopi