[Python Dev] Fix crash with empty args for isin | Fix transformation for isnotin
#16271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! LGTM - should this go into main or v1.2? |
|
Hmm yes and no, I'm not sure about the |
|
I think rebasing to v1.2.1 makes sense, could you rebase? |
…' for NOT IN, properly use COMPARE_NOT_IN
1937e5f to
4f69a1d
Compare
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Fix issue related to hang when all candidates are eliminated in refinement (duckdb/duckdb#16288) [Python Dev] Fix crash with empty args for `isin` | Fix transformation for `isnotin` (duckdb/duckdb#16271) [Dev] `register_filesystem` stubs, use `fsspec.AbstractFileSystem`, not `str` (duckdb/duckdb#16266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16265
While I was at it, I realized that
isnotindoesn't transform correctly, it should useExpressionType::COMPARE_NOT_IN, not just wrap theCOMPARE_INresult with anOPERATOR_NOTI wonder if the optimizer catches this and made this change already, or it doesn't because the behavior is not equivalent for the two cases - either way, better to fix it here.