Avoid calling SetFilterAlwaysTrue multiple times in RowGroup::CheckZonemap #16269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Avoid calling SetFilterAlwaysTrue multiple times in RowGroup::CheckZonemap (duckdb/duckdb#16269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During row group checks - we keep track of which filters are always true (and hence do not need to be checked during the actual scan). Due to a missing
elsestatement, we could call this method twice for the same filter.Now this doesn't look problematic, but in
SetFilterAlwaysTruewe also keep track of how many filters have been set as being always true - and if all filters are set as being always true, the filters are skipped entirely.This can cause problems when optional filters (as e.g. constructed due to a Top-N) are combined with non-optional filters (as e.g. constructed through a
WHEREclause). The filter would not be correctly executed - leading to incorrect rows sneaking into the result.