Skip to content

Correctly report errors caused by get_database in C extensions #16253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2025
Merged

Correctly report errors caused by get_database in C extensions #16253

merged 2 commits into from
Feb 16, 2025

Conversation

mlafeldt
Copy link
Member

@mlafeldt mlafeldt commented Feb 15, 2025 •
edited
Loading

Errors are only reported if has_error is true, which is only set for get_api but not for get_database.

duckdb/src/main/extension/extension_load.cpp

Lines 570 to 574 in 5f5512b

// Throw any error that the extension might have encountered
if (load_state.has_error) {
load_state.error_data.Throw("An error was thrown during initialization of the extension '" + extension +
"': ");
}

@mlafeldt
Copy link
Member Author

The failure in LinuxRelease is unrelated: error: https://github.com/boostorg/range/archive/boost-1.86.0.tar.gz: curl failed to download with exit code 92

@Mytherin
Copy link
Collaborator

Thanks for the PR! Looks good - could you perhaps retarget this to v1.2-histrionicus so that it can be included in v1.2.1?

@mlafeldt mlafeldt changed the base branch from main to v1.2-histrionicus February 16, 2025 13:42
@mlafeldt mlafeldt force-pushed the fix-get-database-error-reporting branch from 23e0d8a to a46237b Compare February 16, 2025 13:45
@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 16, 2025 13:46
@mlafeldt mlafeldt marked this pull request as ready for review February 16, 2025 13:46
@mlafeldt
Copy link
Member Author

@Mytherin Of course, done.

@Mytherin Mytherin merged commit 2b87326 into duckdb:v1.2-histrionicus Feb 16, 2025
50 checks passed
@mlafeldt mlafeldt deleted the fix-get-database-error-reporting branch March 6, 2025 08:57
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Mar 7, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@2b87326
19c042f 
Correctly report errors caused by get_database in C extensions (duckdb/duckdb#16253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlafeldt @Mytherin