Skip to content

Deleted copy constructor of pending query #16242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2025
Merged

Deleted copy constructor of pending query #16242

merged 2 commits into from
Feb 16, 2025

Conversation

NiclasHaderer
Copy link
Contributor

Having a non-deleted copy constructor allows me to write the following code, which crashes

DuckDB duckdb(nullptr);
Connection con(duckdb);
auto pending = con.PendingQuery("FROM range(1000)");
auto pending2 = *pending;

pending2.Execute(); // Crashes -> Attempting to execute an unsuccessful or closed pending query result

@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 14, 2025 13:33
@NiclasHaderer NiclasHaderer marked this pull request as ready for review February 14, 2025 13:35
@Mytherin Mytherin merged commit dfdd6a5 into duckdb:v1.2-histrionicus Feb 16, 2025
50 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Mar 7, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@dfdd6a5
114903d 
Deleted copy constructor of pending query (duckdb/duckdb#16242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiclasHaderer @Mytherin