Parquet reader: push table filters directly into dictionaries #16136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying dict filter (1 / 115067)
|
Actually I just realized a cool optimization that we could implement based on this - if the dictionary filters out all values, we don't even need to read the offset page and can skip it entirely. |
…that no rows need to be read
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Parquet reader: push table filters directly into dictionaries (duckdb/duckdb#16136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
DictionaryDecoder- if we are executing a filter, we can execute the filter once on the dictionary. We can then figure out if a value is filtered out or not by looking at the filter result for each dictionary value.