Skip to content

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Feb 7, 2025

This is on top of #16107, but while that bit is trivial, this might require adapting logic to check nightly runs.

@hmeriann
Copy link
Contributor

hmeriann commented Feb 7, 2025

This definitely requires updates in checking nightly-builds.
Could you please clarify, @carlopi , how would it be possible to determine if it is the nightly-build for Linux, OSX, R, Windows, Python, Wasm? Will the nightly-builds even created, if these workflow's runs will not be triggered by event repository_dispatch?

@carlopi
Copy link
Contributor Author

carlopi commented Feb 7, 2025

We need to go over this together, I think the goal should be having release process (both for actual releases and releases candidates) AND nightly testing to be as closely aligned as possible. There might be better way forward, not ready to be merged.
I have converted this to draft.

@carlopi carlopi marked this pull request as draft February 7, 2025 09:05
@carlopi carlopi marked this pull request as ready for review February 7, 2025 14:43
Copy link
Contributor

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mytherin Mytherin merged commit e9ed3ac into duckdb:main Feb 11, 2025
75 of 76 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@carlopi carlopi deleted the rework_invoke branch February 11, 2025 08:53
Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 27, 2025
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants