Skip to content

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 12, 2025

As documented in C++ STL doc for steady_clock:

This clock is not related to wall clock time (for example, it can be time since last reboot), and is most suitable 
for measuring intervals.

@Mytherin
Copy link
Collaborator

Thanks! Looks good to me - could you just fix the CI?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 12, 2025 12:11
@dentiny dentiny marked this pull request as ready for review February 12, 2025 12:11
@dentiny
Copy link
Contributor Author

dentiny commented Feb 12, 2025

Thanks! Looks good to me - could you just fix the CI?

Ah sorry I forgot to run linter before PR; just fixed locally and should be good now!

@dentiny dentiny force-pushed the hjiang/use-steady-clock-for-profiler branch from bfbb305 to 054565b Compare February 12, 2025 13:22
@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 12, 2025 13:23
@Mytherin Mytherin marked this pull request as ready for review February 12, 2025 17:02
@Mytherin Mytherin merged commit 1734288 into duckdb:main Feb 13, 2025
49 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 27, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
Use steady clock for profiler (duckdb/duckdb#16198)
[Python][Dev] Replace the default connection when it's closed (duckdb/duckdb#16160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants