Ensure that dependent targets are present after find_package. #16197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckDBConfig.cmake.in: * Ensure that Threads::Threads is available with find_dependency, as it is unconditionally used: https://github.com/duckdb/duckdb/blob/60c94425622338fc47ffcd646dd5181f734d364d/CMakeLists.txt#L25 * If external ICU is selected, ensure that its targets are available. extension\icu\CMakeLists.txt: Add missing uc component.
BillyONeal
commented
Feb 12, 2025
| REQUIRED) | ||
| target_link_libraries(icu_extension ICU::i18n) | ||
| target_link_libraries(icu_extension ICU::i18n ICU::uc) |
There was a problem hiding this comment.
It looks like this was missed because we forgot to set WITH_INTERNAL_ICU=OFF :)
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Parquet Writer Cleanup: Move ColumnWriters to separate files (duckdb/duckdb#16202) Concurrency groups for R and Wasm (duckdb/duckdb#16201) Ensure that dependent targets are present after find_package. (duckdb/duckdb#16197) Bump Julia (duckdb/duckdb#16199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDBConfig.cmake.in:
Ensure that Threads::Threads is available with find_dependency, as it is unconditionally used:
duckdb/CMakeLists.txt
Line 25 in 60c9442
If external ICU is selected, ensure that its targets are available.
extension\icu\CMakeLists.txt: Add missing uc component; followup from #16176