Parquet reader: batch check if buffer is available in RLEBpDecoder #16185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Parquet reader: batch check if buffer is available in RLEBpDecoder (duckdb/duckdb#16185) Unvendor ICU (duckdb/duckdb#16176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading long chains of
RleBpDecoderdata -NextCountscan be called many times. Instead of checking if there is enough buffer available for every byte we can batch check if we are certain we have enough bytes available. The varint that we are reading is limited to max 5 bytes (as more does not fit into auint32_t) so we can just callcheck_availableonce. This improves performance by ~10% when reading data with many small batches.