-
Notifications
You must be signed in to change notification settings - Fork 2.5k
unified names for duckdb-extensions #16179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there are 2 change-sets in this PR, the one connected to extensions and the one connected to binaries. I would separate the 2 since they are logically independent. Extensions: LGTM, change should not be visible to external world (since it changed already a few times / it's recent / extensions you can get them through regular INSTALL) Binaries: I am not sure I see it AND it's independent, so I would remove from PR and discuss that independently. In particular, Linux binaries are distributed like:
that seems consistent to the Windows pre-this change. Change can have sense, but it's more visible (since nightly download endpoint uses that) and would make more sense across the board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great the extension part, I would revert the Windows binaries part.
yes! And It makes sense that changes to the binaries names and to the extensions names should be PR'ed separately. I'll remove changes to binaries names from this PR and will open a follow-up PR with them |
I think in the case of LinuxRelease:
so it then becomes |
Thanks!! |
I don't think that
|
Thanks! |
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)
Currently, the naming pattern for DuckDB extensions is inconsistent with the naming pattern used for DuckDB binaries.
Specifically:
This PR aligns the naming pattern for extensions across all platforms to use
duckdb-extensions-${{ matrix.duckdb_arch }}