Parquet: Add dedicated Select method that can be used to push selection vectors into the read #16174
+145
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Parquet: Add dedicated Select method that can be used to push selection vectors into the read (duckdb/duckdb#16174) [CI] Avoid Linux CLI jobs to fail-fast (duckdb/duckdb#16173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively restores a previous optimization where we would skip reading elements if they were previously filtered out. For now we only enable this for strings - that has by far the highest performance benefits as we can skip UTF8 validation for any strings that we don't need to read.
For simple types like integers this optimization is not so straightforwardly useful - as we effectively replace a
memcpywith a branchy lookup. I haven't run any benchmarks on this yet but I suspect that the usefulness of this optimization depends on selectivity - i.e. it might perform better when the selectivity is <10% (or some other to be determined threshold). I will leave that for a future PR.