Parquet Reader: Split CreateReader into two separate stages - ParseSchema and CreateReader
#16161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rquet Schema, the other to actually create the column readers)
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161) Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155) Hopefully fixing ci runs (duckdb/duckdb#16150) Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Parquet reader uses the ColumnReader for two purposes:
This PR splits up these two cases. The
ParquetColumnSchemaclass is added which fulfills the first purpose. The newParseSchemamethod looks at a Parquet schema and converts that into aParquetColumnSchema. This is used in theParquetReaderto obtain the result types of the file.The column readers are now created using the
CreateReadermethod based on theParquetColumnSchemaobjects. As a result, creating the column readers is significantly simpler (as the Parquet metadata has already been parsed at this stage). We can also avoid creating column readers for columns we are not going to read - which can lead to significant performance improvements when we are only reading a small subset of the columns when reading small-ish files.